linux-kernel - Re: [PATCH v2] staging: greybus: remove tabs to fix line length and merge lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6418fb683bc37_2c7706294e3@iweiny-mobl.notmuch>
Date:   Mon, 20 Mar 2023 17:33:44 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     Khadija Kamran <kamrankhadijadj@...il.com>,
        Ira Weiny <ira.weiny@...el.com>
CC:     <outreachy@...ts.linux.dev>,
        Vaibhav Hiremath <hvaibhav.linux@...il.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        <greybus-dev@...ts.linaro.org>, <linux-staging@...ts.linux.dev>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] staging: greybus: remove tabs to fix line length and
 merge lines

Khadija Kamran wrote:
> On Sun, Mar 12, 2023 at 06:01:03PM -0700, Ira Weiny wrote:
> > Khadija Kamran wrote:
> > > In file drivers/staging/greybus/arche-platform.c,
> > > - Length of line 181 exceeds 100 columns, fix by removing tabs from the
> > >   line.
> > > - If condition and spin_unlock_...() call is split into two lines, join
> > > them to form a single line.
> > > 
> > > Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
> > 
> > Fundamentally the problem with arche_platform_wd_irq() is that the
> > indentation is too great.
> > 
> > "... if you need more than 3 levels of indentation, you’re screwed anyway,
> > and should fix your program."
> > 
> > 	-- https://www.kernel.org/doc/html/v4.10/process/coding-style.html#indentation
> > 
> > I think a better solution would be to refactor the entire function.  This
> > would make the logic of the function more clear as well IMHO.
> > 
> > Here is another tip to help:
> > 
> > https://www.kernel.org/doc/html/v4.10/process/coding-style.html#centralized-exiting-of-functions
> > 
> > Do you think you could try that?
> 
> Hey Ira!
> 
> Sorry about the late reply. Thank you for your feedback. I have looked
> into the above link. Are you referring to the use of goto statements in
> arche_platform_wd_irq() call?

I'm not quite sure I understand what you mean because currently
arche_platform_wd_irq() does not use gotos.

But I think you are asking if I think it should.  If that is what you mean
then 'yes' I think arche_platform_wd_irq() could use goto's to clean up
the flow.

Ira