linux-kernel - Re: [PATCH v2 1/2] mfd: tps6586x: use devm-based power off handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2023 05:17:08 +0300
From:   Dmitry Osipenko <dmitry.osipenko@...labora.com>
To:     Benjamin Bara <bbara93@...il.com>, lee@...nel.org
Cc:     jonathanh@...dia.com, treding@...dia.com,
        richard.leitner@...ux.dev, benjamin.bara@...data.com,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] mfd: tps6586x: use devm-based power off handler

On 3/21/23 01:03, Benjamin Bara wrote:
> +static int tps6586x_power_off_handler(struct sys_off_data *data)
>  {
> -	if (tps6586x_clr_bits(tps6586x_dev, TPS6586X_SUPPLYENE, EXITSLREQ_BIT))
> -		return;
> +	int ret;

Nit: "int ret" should be put after "struct tps6586x_dev" to adhere
canonical kernel coding style

> +	struct device *tps6586x_dev = (struct device *)data->cb_data;

No need for casting of the void* type

-- 
Best regards,
Dmitry