linux-kernel - Re: [PATCH v2 2/2] mfd: tps6586x: register restart handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9d9ad38-3743-1cff-2b47-75d1ecdc6f81@collabora.com>
Date:   Tue, 21 Mar 2023 05:07:44 +0300
From:   Dmitry Osipenko <dmitry.osipenko@...labora.com>
To:     Benjamin Bara <bbara93@...il.com>, lee@...nel.org,
        Wolfram Sang <wsa@...nel.org>
Cc:     jonathanh@...dia.com, treding@...dia.com,
        richard.leitner@...ux.dev, benjamin.bara@...data.com,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] mfd: tps6586x: register restart handler

On 3/21/23 01:03, Benjamin Bara wrote:
> +static int tps6586x_restart_handler(struct sys_off_data *data)
> +{
> +	unsigned long flags;
> +	struct device *tps6586x_dev = (struct device *)data->cb_data;
> +
> +	/* bring pmic into HARD REBOOT state, enforce atomic i2c xfer */
> +	local_irq_save(flags);
> +	tps6586x_set_bits(tps6586x_dev, TPS6586X_SUPPLYENE, SOFT_RST_BIT);
> +	local_irq_restore(flags);

Please change i2c_in_atomic_xfer_mode() to use preemptible() instead of
irqs_disabled() and drop the local_irq_save/restore.

-- 
Best regards,
Dmitry