[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZBmtu4klxYwQyN7R@hovoldconsulting.com>
Date: Tue, 21 Mar 2023 14:14:35 +0100
From: Johan Hovold <johan@...nel.org>
To: Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
Neil Armstrong <neil.armstrong@...aro.org>
Cc: Johan Hovold <johan+linaro@...nel.org>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Kevin Hilman <khilman@...libre.com>,
Jerome Brunet <jbrunet@...libre.com>,
dri-devel@...ts.freedesktop.org, linux-amlogic@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
stable@...r.kernel.org
Subject: Re: [PATCH] drm/meson: fix missing component unbind on bind errors
On Thu, Mar 09, 2023 at 10:41:18PM +0100, Martin Blumenstingl wrote:
> On Mon, Mar 6, 2023 at 11:35 AM Johan Hovold <johan+linaro@...nel.org> wrote:
> [...]
> > @@ -325,23 +325,23 @@ static int meson_drv_bind_master(struct device *dev, bool has_components)
> >
> > ret = meson_encoder_hdmi_init(priv);
> I'm wondering if component_bind_all() can be moved further down.
> Right now it's between meson_encoder_cvbs_init() and
> meson_encoder_hdmi_init(). So it seems that encoders don't rely on
> component registration.
Perhaps it can, but that would be a separate change (unless there is
something inherently wrong with the current initialisation order).
> Unfortunately I am also not familiar with this and I'm hoping that
> Neil can comment on this.
Any comments on this one, Neil?
Johan
Powered by blists - more mailing lists