linux-kernel - Re: [PATCH] drm/bridge: display-connector: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Mar 2023 10:35:35 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     ye.xingchen@....com.cn
Cc:     andrzej.hajda@...el.com, neil.armstrong@...aro.org,
        rfoss@...nel.org, jonas@...boo.se, jernej.skrabec@...il.com,
        airlied@...il.com, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: display-connector: Use dev_err_probe()

Hi Ye,

Thank you for the patch.

On Wed, Mar 22, 2023 at 04:21:33PM +0800, ye.xingchen@....com.cn wrote:
> From: Ye Xingchen <ye.xingchen@....com.cn>
> 
> Replace the open-code with dev_err_probe() to simplify the code.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@....com.cn>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/gpu/drm/bridge/display-connector.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c
> index fbb3e102c02f..56ae511367b1 100644
> --- a/drivers/gpu/drm/bridge/display-connector.c
> +++ b/drivers/gpu/drm/bridge/display-connector.c
> @@ -271,12 +271,9 @@ static int display_connector_probe(struct platform_device *pdev)
>  	    type == DRM_MODE_CONNECTOR_DisplayPort) {
>  		conn->hpd_gpio = devm_gpiod_get_optional(&pdev->dev, "hpd",
>  							 GPIOD_IN);
> -		if (IS_ERR(conn->hpd_gpio)) {
> -			if (PTR_ERR(conn->hpd_gpio) != -EPROBE_DEFER)
> -				dev_err(&pdev->dev,
> -					"Unable to retrieve HPD GPIO\n");
> -			return PTR_ERR(conn->hpd_gpio);
> -		}
> +		if (IS_ERR(conn->hpd_gpio))
> +			return dev_err_probe(&pdev->dev, PTR_ERR(conn->hpd_gpio),
> +					     "Unable to retrieve HPD GPIO\n");
> 
>  		conn->hpd_irq = gpiod_to_irq(conn->hpd_gpio);
>  	} else {

-- 
Regards,

Laurent Pinchart