linux-kernel - Re: [PATCH RESEND v2 09/11] scsi: scsi_debug: Drop sdebug_dev_info.num_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Mar 2023 13:36:16 +0000
From:   John Garry <john.g.garry@...cle.com>
To:     kernel test robot <oliver.sang@...el.com>
Cc:     oe-lkp@...ts.linux.dev, lkp@...el.com, linux-scsi@...r.kernel.org,
        jejb@...ux.ibm.com, martin.petersen@...cle.com, bvanassche@....org,
        linux-kernel@...r.kernel.org, dgilbert@...erlog.com
Subject: Re: [PATCH RESEND v2 09/11] scsi: scsi_debug: Drop
 sdebug_dev_info.num_in_q

On 20/03/2023 11:41, John Garry wrote:
>> scsi/004 (ensure repeated TASK SET FULL results in EIO on timing out 
>> command) [failed]
>>      runtime    ...  1.467s
>>      --- tests/scsi/004.out    2023-02-28 16:52:49.000000000 +0000
>>      +++ /lkp/benchmarks/blktests/results/nodev/scsi/004.out.bad    
>> 2023-03-18 00:19:00.232079954 +0000
>>      @@ -1,3 +1,2 @@
>>       Running scsi/004
>>      -Input/output error
>>       Test complete
>>
> 
> I'll check this now.

This should fix it:

--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -5580,7 +5580,7 @@ static int schedule_resp(struct scsi_cmnd *cmnd, 
struct sdebug_dev_info *devip,
                 int num_in_q = scsi_device_busy(sdp);
                 int qdepth = cmnd->device->queue_depth;

-               if ((num_in_q == (qdepth - 1)) &&
+               if ((num_in_q == qdepth) &&
                     (atomic_inc_return(&sdebug_a_tsf) >=


I'll send that change in my other scsi_debug series after I test further.