linux-kernel - Re: [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Mar 2023 17:19:15 +0100
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Christoph Hellwig <hch@...radead.org>, ye.xingchen@....com.cn
Cc:     mcgrof@...nel.org, keescook@...omium.org, yzaikin@...gle.com,
        akpm@...ux-foundation.org, linmiaohe@...wei.com,
        chi.minghao@....com.cn, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own
 file

On 3/22/23 09:35, Christoph Hellwig wrote:
> On Wed, Mar 22, 2023 at 10:46:28AM +0800, ye.xingchen@....com.cn wrote:
>> From: Minghao Chi <chi.minghao@....com.cn>
>> 
>> This moves all compaction sysctls to its own file.
> 
> So there's a whole lot of these 'move sysctrls to their own file'
> patches, but no actual explanation of why that is desirable.  Please

I think Luis started this initiative, maybe he can provide the canonical
reasoning :)

> explain why we'd want to split code that is closely related, and now
> requires marking symbols non-static just to create a new tiny source
> file.

Hmm? I can see the opposite, at least in the compaction patch here. Related
code and variables are moved closer together, made static, declarations
removed from headers. It looks like an improvement to me.