linux-kernel - Re: [PATCH] RAS/CEC: Move non-debug attributes out of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW5PR84MB171359C71BF003E287E2323C9B879@MW5PR84MB1713.NAMPRD84.PROD.OUTLOOK.COM>
Date:   Thu, 23 Mar 2023 21:52:01 +0000
From:   "Meyer, Kyle" <kyle.meyer@....com>
To:     Dave Hansen <dave.hansen@...el.com>,
        "Sivanich, Dimitri" <dimitri.sivanich@....com>,
        "Wahl, Steve" <steve.wahl@....com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "qiuxu.zhuo@...el.com" <qiuxu.zhuo@...el.com>,
        "yazen.ghannam@....com" <yazen.ghannam@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Subject: Re: [PATCH] RAS/CEC: Move non-debug attributes out of debugfs

> You forgot to attach the patch that you wrote that updates
> Documentation/ABI/. ;)

Thanks, I will include the documentation with a second version of the
patch.

> Also, why *should* these be part of the stable sysfs ABI?  What app is
> using them?  Why does it need them?

We have system scripts that adjust decay_interval and action_threshold.
They can't access those attributes when lockdown is enabled. If there is a
more appropriate place for those attributes, please let me know.

> Why these two and only these two? What's left in debugfs?

The other attributes (pfn and array) are used to test CEC. They are only
created when RAS_CEC_DEBUG is enabled. 

Thanks,
Kyle Meyer