linux-kernel - Re: [PATCH] RAS/CEC: Move non-debug attributes out of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3a47826-881f-6542-5db2-63ebf1705cb6@intel.com>
Date:   Thu, 23 Mar 2023 15:01:21 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     "Meyer, Kyle" <kyle.meyer@....com>,
        "Sivanich, Dimitri" <dimitri.sivanich@....com>,
        "Wahl, Steve" <steve.wahl@....com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>,
        "yazen.ghannam@....com" <yazen.ghannam@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Subject: Re: [PATCH] RAS/CEC: Move non-debug attributes out of debugfs

On 3/23/23 14:52, Meyer, Kyle wrote:
>> Also, why *should* these be part of the stable sysfs ABI?  What app is
>> using them?  Why does it need them?
> We have system scripts that adjust decay_interval and action_threshold.
> They can't access those attributes when lockdown is enabled. If there is a
> more appropriate place for those attributes, please let me know.

Thanks for the info.  That helps a bit.  But, I'd also appreciate if you
could expand on this a little more.  What "system scripts" are these?
Who is using them?  What are they trying to accomplish?

We can try to find the best home for these attributes with that info in
hand, if it's not sysfs.

>> Why these two and only these two? What's left in debugfs?
> The other attributes (pfn and array) are used to test CEC. They are only
> created when RAS_CEC_DEBUG is enabled.

Oh, that's good info too.  Can you please include that in some form in
your new changelog?