linux-kernel - Re: [PATCH] mmc: sdricoh_cs: remove unused sdricoh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFqfdYKXwaCbT6_hBsX1ZxeVtNivZBQmh3gA8554F944hA@mail.gmail.com>
Date:   Thu, 23 Mar 2023 13:13:25 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Tom Rix <trix@...hat.com>
Cc:     saschasommer@...enet.de, nathan@...nel.org,
        ndesaulniers@...gle.com, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] mmc: sdricoh_cs: remove unused sdricoh_readw function

On Sun, 19 Mar 2023 at 17:47, Tom Rix <trix@...hat.com> wrote:
>
> clang with W=1 reports
> drivers/mmc/host/sdricoh_cs.c:104:28: error: unused function
>   'sdricoh_readw' [-Werror,-Wunused-function]
> static inline unsigned int sdricoh_readw(struct sdricoh_host *host,
>                            ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@...hat.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdricoh_cs.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdricoh_cs.c
> index 76a8cd3a186f..57b8c1a96756 100644
> --- a/drivers/mmc/host/sdricoh_cs.c
> +++ b/drivers/mmc/host/sdricoh_cs.c
> @@ -101,14 +101,6 @@ static inline void sdricoh_writel(struct sdricoh_host *host, unsigned int reg,
>
>  }
>
> -static inline unsigned int sdricoh_readw(struct sdricoh_host *host,
> -                                        unsigned int reg)
> -{
> -       unsigned int value = readw(host->iobase + reg);
> -       dev_vdbg(host->dev, "rb %x 0x%x\n", reg, value);
> -       return value;
> -}
> -
>  static inline void sdricoh_writew(struct sdricoh_host *host, unsigned int reg,
>                                          unsigned short value)
>  {
> --
> 2.27.0
>