linux-kernel - Re: [PATCH v3 6/6] pinctrl: s32: separate const device data from struct s32_pinctrl_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZB1VLbvTudD2Ye5C@linux-8mug>
Date:   Fri, 24 Mar 2023 15:45:49 +0800
From:   Chester Lin <clin@...e.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        NXP S32 Linux Team <s32@....com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Ghennadi Procopciuc <Ghennadi.Procopciuc@....nxp.com>,
        Andrei Stefanescu <andrei.stefanescu@....com>,
        Radu Pirea <radu-nicolae.pirea@....com>,
        Andreas Färber <afaerber@...e.de>,
        Matthias Brugger <mbrugger@...e.com>
Subject: Re: [PATCH v3 6/6] pinctrl: s32: separate const device data from
 struct s32_pinctrl_soc_info

Hi Andy,

Thanks for reviewing this patch!

On Thu, Mar 23, 2023 at 08:50:41PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 23, 2023 at 4:49 PM Chester Lin <clin@...e.com> wrote:
> >
> > The .data field in struct of_device_id is used as a const member so it's
> > inappropriate to attach struct s32_pinctrl_soc_info with of_device_id
> > because some members in s32_pinctrl_soc_info need to be filled by
> > pinctrl-s32cc at runtime.
> >
> > For this reason, struct s32_pinctrl_soc_info must be allocated in
> > pinctrl-s32cc and then create a new struct s32_pinctrl_soc_data in order
> > to represent const .data in of_device_id. To combine these two structures,
> > a s32_pinctrl_soc_data pointer is introduced in s32_pinctrl_soc_info.
> 
> So, the first patch has to be embedded in this one, correct?

Correct. Leave the first patch alone will cause a compiler warning.

> Don't forget to compile and test your contributions beforehand.

Will do.

Regards,
Chester

> 
> -- 
> With Best Regards,
> Andy Shevchenko