linux-kernel - Re: [PATCH] driver core: class: mark the struct class for sysfs callbacks as constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCG+uH4Dh16Gwonj@bombadil.infradead.org>
Date:   Mon, 27 Mar 2023 09:05:12 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        Johannes Berg <johannes@...solutions.net>,
        Linus Walleij <linus.walleij@...aro.org>,
        Minchan Kim <minchan@...nel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Namjae Jeon <linkinjeon@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Russ Weight <russell.h.weight@...el.com>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steve French <sfrench@...ba.org>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-cifs@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-mtd@...ts.infradead.org, linux-rdma@...r.kernel.org,
        linux-s390@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] driver core: class: mark the struct class for sysfs
 callbacks as constant

On Sat, Mar 25, 2023 at 09:45:37AM +0100, Greg Kroah-Hartman wrote:
> struct class should never be modified in a sysfs callback as there is
> nothing in the structure to modify, and frankly, the structure is almost
> never used in a sysfs callback, so mark it as constant to allow struct
> class to be moved to read-only memory.
> 
> While we are touching all class sysfs callbacks also mark the attribute
> as constant as it can not be modified.  The bonding code still uses this
> structure so it can not be removed from the function callbacks.
> 
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Reviewed-by: Luis Chamberlain <mcgrof@...nel.org>

  Luis