linux-kernel - Re: [PATCH v4 4/7] soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCH4yE9nmj/3e1Vx@gmail.com>
Date:   Mon, 27 Mar 2023 20:12:56 +0000
From:   Eric Biggers <ebiggers@...nel.org>
To:     Bjorn Andersson <andersson@...nel.org>
Cc:     Abel Vesa <abel.vesa@...aro.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        Bart Van Assche <bvanassche@....org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-msm@...r.kernel.org, linux-crypto@...r.kernel.org,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH v4 4/7] soc: qcom: Make the Qualcomm UFS/SDCC ICE a
 dedicated driver

On Mon, Mar 27, 2023 at 12:27:04PM -0700, Bjorn Andersson wrote:
> 
> That's a valid reason that I was looking for. Wouldn't this be a common
> problem, something other parts of the stack would like to avoid?
> Or it's just a byte array until we get here?
> 
> > It could be done with unaligned memory accesses, though, if you prefer that:
> > 
> 
> No need to jump through the hoops, but a comment would have saved
> (robbed?) me from wondering.

The parameter to qcom_ice_program_key() is 'const u8 crypto_key[]', which has no
inherent alignment in the type.  It might be that the callers currently only
pass 4-byte aligned buffers, but I don't think that should be relied on here.

- Eric