linux-kernel - [PATCH 12/12] drm/amd/display: Remove two unused variables 'result_write_min_hblank' and 'hblank

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230327233353.64081-13-caionovais@usp.br>
Date:   Mon, 27 Mar 2023 20:33:53 -0300
From:   Caio Novais <caionovais@....br>
To:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Cc:     Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Jack Xiao <Jack.Xiao@....com>,
        Hawking Zhang <Hawking.Zhang@....com>, Le Ma <le.ma@....com>,
        Mario Limonciello <mario.limonciello@....com>,
        Yifan Zhang <yifan1.zhang@....com>,
        Mukul Joshi <mukul.joshi@....com>, Jun Lei <Jun.Lei@....com>,
        Wenjing Liu <wenjing.liu@....com>,
        Alan Liu <HaoPing.Liu@....com>,
        Caio Novais <caionovais@....br>,
        Joshua Ashton <joshua@...ggi.es>,
        Guo Zhengkui <guozhengkui@...o.com>,
        Nicholas Kazlauskas <Nicholas.Kazlauskas@....com>,
        Zhan Liu <zhan.liu@....com>, Wayne Lin <wayne.lin@....com>,
        Charlene Liu <Charlene.Liu@....com>,
        Martin Leung <Martin.Leung@....com>,
        Tom Chung <chiahsuan.chung@....com>,
        Alvin Lee <alvin.lee2@....com>,
        George Shen <George.Shen@....com>,
        Qingqing Zhuo <qingqing.zhuo@....com>,
        Roman Li <Roman.Li@....com>,
        Wesley Chalmers <Wesley.Chalmers@....com>,
        Aurabindo Pillai <aurabindo.pillai@....com>,
        Jingwen Zhu <Jingwen.Zhu@....com>,
        Melissa Wen <mwen@...lia.com>,
        Felipe Clark <felipe.clark@....com>,
        Sung Joon Kim <sungjoon.kim@....com>,
        Dillon Varone <Dillon.Varone@....com>,
        Ethan Wellenreiter <Ethan.Wellenreiter@....com>,
        Taimur Hassan <Syed.Hassan@....com>,
        Maíra Canal <mairacanal@...eup.net>,
        Brian Chang <Brian.Chang@....com>,
        Gabe Teeger <gabe.teeger@....com>,
        André Almeida <andrealmeid@...lia.com>,
        Chaitanya Dhere <chaitanya.dhere@....com>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Ryan Lin <tsung-hua.lin@....com>,
        Hamza Mahfooz <hamza.mahfooz@....com>
Subject: [PATCH 12/12] drm/amd/display: Remove two unused variables 'result_write_min_hblank' and 'hblank_size'

Compiling AMD GPU drivers displays a warning:

drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c: In function ‘dpcd_set_source_specific_data’:
drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c:1290:32: warning: variable ‘result_write_min_hblank’ set but not used [-Wunused-but-set-variable]

Get rid of it by removing the variable 'result_write_min_hblank' and 'hblank_size'.

Signed-off-by: Caio Novais <caionovais@....br>
---
 .../drm/amd/display/dc/link/protocols/link_dp_capability.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
index d4370856f164..7392fcf17653 100644
--- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
+++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
@@ -1287,7 +1287,6 @@ void dc_link_overwrite_extended_receiver_cap(
 void dpcd_set_source_specific_data(struct dc_link *link)
 {
 	if (!link->dc->vendor_signature.is_valid) {
-		enum dc_status result_write_min_hblank = DC_NOT_SUPPORTED;
 		struct dpcd_amd_signature amd_signature = {0};
 		struct dpcd_amd_device_id amd_device_id = {0};
 
@@ -1324,16 +1323,10 @@ void dpcd_set_source_specific_data(struct dc_link *link)
 		if (link->ctx->dce_version >= DCN_VERSION_2_0 &&
 			link->dc->caps.min_horizontal_blanking_period != 0) {
 
-			uint8_t hblank_size = (uint8_t)link->dc->caps.min_horizontal_blanking_period;
-
-			result_write_min_hblank = core_link_write_dpcd(link,
-				DP_SOURCE_MINIMUM_HBLANK_SUPPORTED, (uint8_t *)(&hblank_size),
-				sizeof(hblank_size));
 		}
 		DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_INFORMATION,
 							WPP_BIT_FLAG_DC_DETECTION_DP_CAPS,
 							"result=%u link_index=%u enum dce_version=%d DPCD=0x%04X min_hblank=%u branch_dev_id=0x%x branch_dev_name='%c%c%c%c%c%c'",
-							result_write_min_hblank,
 							link->link_index,
 							link->ctx->dce_version,
 							DP_SOURCE_MINIMUM_HBLANK_SUPPORTED,
-- 
2.40.0