linux-kernel - Re: [PATCH 01/12] drm/amd: Remove unused variable 'r'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Mar 2023 19:46:25 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Caio Novais <caionovais@....br>
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, Felipe Clark <felipe.clark@....com>,
        Wenjing Liu <wenjing.liu@....com>,
        Maíra Canal <mairacanal@...eup.net>,
        Mario Limonciello <mario.limonciello@....com>,
        Jun Lei <Jun.Lei@....com>, Charlene Liu <Charlene.Liu@....com>,
        Gabe Teeger <gabe.teeger@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Taimur Hassan <Syed.Hassan@....com>,
        Aurabindo Pillai <aurabindo.pillai@....com>,
        Alvin Lee <alvin.lee2@....com>,
        George Shen <George.Shen@....com>,
        Hamza Mahfooz <hamza.mahfooz@....com>,
        Chaitanya Dhere <chaitanya.dhere@....com>,
        Alan Liu <HaoPing.Liu@....com>,
        Mukul Joshi <mukul.joshi@....com>,
        André Almeida <andrealmeid@...lia.com>,
        Jingwen Zhu <Jingwen.Zhu@....com>,
        Guo Zhengkui <guozhengkui@...o.com>,
        Leo Li <sunpeng.li@....com>, Melissa Wen <mwen@...lia.com>,
        Le Ma <le.ma@....com>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Martin Leung <Martin.Leung@....com>,
        Ryan Lin <tsung-hua.lin@....com>,
        Brian Chang <Brian.Chang@....com>,
        Sung Joon Kim <sungjoon.kim@....com>,
        Yifan Zhang <yifan1.zhang@....com>,
        Jack Xiao <Jack.Xiao@....com>,
        Dillon Varone <Dillon.Varone@....com>,
        Tom Chung <chiahsuan.chung@....com>,
        Wesley Chalmers <Wesley.Chalmers@....com>,
        Qingqing Zhuo <qingqing.zhuo@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>, Zhan Liu <zhan.liu@....com>,
        Roman Li <Roman.Li@....com>,
        Christian König <christian.koenig@....com>,
        Wayne Lin <wayne.lin@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Ethan Wellenreiter <Ethan.Wellenreiter@....com>,
        Nicholas Kazlauskas <Nicholas.Kazlauskas@....com>,
        Joshua Ashton <joshua@...ggi.es>,
        Hawking Zhang <Hawking.Zhang@....com>
Subject: Re: [PATCH 01/12] drm/amd: Remove unused variable 'r'

On Mon, Mar 27, 2023 at 7:34 PM Caio Novais <caionovais@....br> wrote:
>
> Compiling AMD GPU drivers displays a warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c: In function ‘amdgpu_mes_ctx_alloc_meta_data’:
> drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c:1099:13: warning: variable ‘r’ set but not used [-Wunused-but-set-variable]
>
> Get rid of it by removing the variable.
>
> Signed-off-by: Caio Novais <caionovais@....br>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> index 82e27bd4f038..e0130536f778 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> @@ -1096,14 +1096,6 @@ uint32_t amdgpu_mes_get_aggregated_doorbell_index(struct amdgpu_device *adev,
>  int amdgpu_mes_ctx_alloc_meta_data(struct amdgpu_device *adev,
>                                    struct amdgpu_mes_ctx_data *ctx_data)
>  {
> -       int r;
> -
> -       r = amdgpu_bo_create_kernel(adev,
> -                           sizeof(struct amdgpu_mes_ctx_meta_data),
> -                           PAGE_SIZE, AMDGPU_GEM_DOMAIN_GTT,
> -                           &ctx_data->meta_data_obj,
> -                           &ctx_data->meta_data_mc_addr,
> -                           &ctx_data->meta_data_ptr);

You can't just remove the buffer allocation here.  If you want to fix
this then do something like
if (r)
    return r;

Alex

>         if (!ctx_data->meta_data_obj)
>                 return -ENOMEM;
>
> --
> 2.40.0
>