lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <2678294.mvXUDI8C0e@steina-w> Date: Mon, 27 Mar 2023 08:27:31 +0200 From: Alexander Stein <alexander.stein@...tq-group.com> To: peng.fan@....nxp.com, linux-arm-kernel@...ts.infradead.org Cc: Markus.Niebel@...tq-group.com, abailon@...libre.com, abelvesa@...nel.org, aford173@...il.com, devicetree@...r.kernel.org, djakov@...nel.org, festevam@...il.com, kernel@...gutronix.de, krzysztof.kozlowski+dt@...aro.org, l.stach@...gutronix.de, laurent.pinchart@...asonboard.com, linux-arm-kernel@...ts.infradead.org, linux-imx@....com, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, marex@...x.de, paul.elder@...asonboard.com, peng.fan@....com, robh+dt@...nel.org, s.hauer@...gutronix.de, shawnguo@...nel.org, gerg@...nel.org, Greg Ungerer <gerg@...ux-m68k.org> Subject: Re: [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio blk ctrl Hi Greg, Am Montag, 27. März 2023, 06:50:37 CEST schrieb Greg Ungerer: > On 2/3/22 17:13, Peng Fan wrote: > > From: Peng Fan <peng.fan@....com> > > > > Add interconnect property for hsio blk ctrl > > > > Signed-off-by: Peng Fan <peng.fan@....com> > > --- > > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index > > 08bd57742294..9cceeeeb26be 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > @@ -1109,6 +1109,11 @@ hsio_blk_ctrl: blk-ctrl@...10000 { > > > > <&pgc_hsiomix>, <&pgc_pcie_phy>; > > > > power-domain-names = "bus", "usb", "usb-phy1", > > > > "usb-phy2", "pcie", "pcie-phy"; > > > > + interconnects = <&noc IMX8MP_ICM_NOC_PCIE &noc IMX8MP_ICN_HSIO>, > > + <&noc IMX8MP_ICM_USB1 &noc IMX8MP_ICN_HSIO>, > > + <&noc IMX8MP_ICM_USB2 &noc IMX8MP_ICN_HSIO>, > > + <&noc IMX8MP_ICM_PCIE &noc IMX8MP_ICN_HSIO>; > > + interconnect-names = "noc-pcie", "usb1", "usb2", "pcie"; > > > > #power-domain-cells = <1>; > > > > }; > > > > }; > > This change completely breaks USB for me on a new iMX8mp platform I am > working with. Before this change normal USB probe looks good: > > xhci-hcd xhci-hcd.0.auto: xHCI Host Controller > xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 1 > xhci-hcd xhci-hcd.0.auto: hcc params 0x0220fe6d hci version 0x110 quirks > 0x0000000000010010 xhci-hcd xhci-hcd.0.auto: irq 206, io mem 0x38100000 > xhci-hcd xhci-hcd.0.auto: xHCI Host Controller > xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 2 > xhci-hcd xhci-hcd.0.auto: Host supports USB 3.0 SuperSpeed > usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, > bcdDevice= 6.03 usb usb1: New USB device strings: Mfr=3, Product=2, > SerialNumber=1 usb usb1: Product: xHCI Host Controller > usb usb1: Manufacturer: Linux 6.3.0-rc4-dirty xhci-hcd > .... > > But after this commit is applied, no USB probe messages at all. > > USB worked fine in 6.0 for me, but when I switched up to 6.1 USB was broken, > I bisected to this as being the offending commit. This is still broken for > me in todays 6.3-rc4. If I revert this change (and only this change) USB > works again. > > Any thoughts on why this breaks USB? Maybe you are missing CONFIG_INTERCONNECT_IMX8MP? Best regards, Alexander -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/
Powered by blists - more mailing lists