[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230327062754.3326-1-clin@suse.com>
Date: Mon, 27 Mar 2023 14:27:49 +0800
From: Chester Lin <clin@...e.com>
To: Linus Walleij <linus.walleij@...aro.org>,
Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Chester Lin <clin@...e.com>, NXP S32 Linux Team <s32@....com>,
linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
Ghennadi Procopciuc <Ghennadi.Procopciuc@....nxp.com>,
Andrei Stefanescu <andrei.stefanescu@....com>,
Radu Pirea <radu-nicolae.pirea@....com>,
Andreas Färber <afaerber@...e.de>,
Matthias Brugger <mbrugger@...e.com>
Subject: [PATCH v5 0/5] pinctrl: s32: driver improvements and generic struct use
Hello,
This patch series contains some improvements for s32 pinctrl drivers suggested
by upstream[1], such as
- Fix error shadowings and improve return value handlings.
- Fix print format.
- Remove unnecessary blanks.
- Use proper macros and helpers to simplify codes.
- Refactor config param parsing and remove config arguments that are never used.
- Use generic struct pingroup and struct pinfunction to describe pin data.
Regards,
Chester
[1] https://lore.kernel.org/all/20230220023320.3499-1-clin@suse.com/
Changes in v5:
- Remove unnecessary (void *) type casting found in pinctrl-s32g2.
Changes in v4:
- Link: https://lore.kernel.org/lkml/20230324143626.16336-1-clin@suse.com/
- Merge the of_device_get_match_data() patch [v3 1/6] into the last patch
[v4 5/5, "pinctrl: s32: separate const device data ..."] in order to solve
compiler warning properly.
Changes in v3:
- Link: https://lore.kernel.org/lkml/20230323144833.28562-1-clin@suse.com/
- Remove unnecessary type casting and correct type qualifiers.
- Split the previous generic-struct patch [v2 4/4] into two separate patches.
- Add a new patch [v3 6/6] to attach a real const .data with of_device_id.
Changes in v2:
- Link: https://lore.kernel.org/lkml/20230320163823.886-1-clin@suse.com/
- Use of_device_get_match_data() to get matched of_device_id data.
- Enhance sizeof() arguments.
- Fix blanks and remove unnecessary parentheses.
- Drop unnecessary marcos and s32_pin_config() implemented in v1 and set/clear
mask/config values transparently.
- Put pull-function related cases together in s32_pin_set_pull().
- Simply use generic 'struct pinfunction' rather than having extra 'struct
s32_pmx_func'.
Chester Lin (5):
pinctrl: s32: refine error/return/config checks and simplify driver
codes
pinctrl: s32cc: refactor pin config parsing
pinctrl: s32cc: embed generic struct pingroup
pinctrl: s32cc: Use generic struct data to describe pin function
pinctrl: s32: separate const device data from struct
s32_pinctrl_soc_info
drivers/pinctrl/nxp/pinctrl-s32.h | 40 ++--
drivers/pinctrl/nxp/pinctrl-s32cc.c | 282 ++++++++++++++++------------
drivers/pinctrl/nxp/pinctrl-s32g2.c | 17 +-
3 files changed, 178 insertions(+), 161 deletions(-)
--
2.37.3
Powered by blists - more mailing lists