linux-kernel - Re: [PATCH v3 2/2] spi: loongson: add bus driver for the loongson spi controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c43019f-01b6-c466-c7d4-c2b91116b7db@linaro.org>
Date:   Mon, 27 Mar 2023 10:53:07 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     zhuyinbo <zhuyinbo@...ngson.cn>, Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Jianmin Lv <lvjianmin@...ngson.cn>, wanghongliang@...ngson.cn,
        Liu Peibao <liupeibao@...ngson.cn>,
        loongson-kernel@...ts.loongnix.cn
Subject: Re: [PATCH v3 2/2] spi: loongson: add bus driver for the loongson spi
 controller

On 27/03/2023 10:42, zhuyinbo wrote:
> 
> 
> 在 2023/3/24 下午7:31, Krzysztof Kozlowski 写道:
>> On 24/03/2023 07:33, Yinbo Zhu wrote:
>>> This bus driver supports the Loongson spi hardware controller in the
>>> Loongson platforms and supports to use DTS and PCI framework to
>>> register spi device resources.
>>>
>>> Signed-off-by: Yinbo Zhu <zhuyinbo@...ngson.cn>
>>> ---
>>>   MAINTAINERS                     |   4 +
>>>   drivers/spi/Kconfig             |  31 ++++
>>>   drivers/spi/Makefile            |   3 +
>>>   drivers/spi/spi-loongson-core.c | 302 ++++++++++++++++++++++++++++++++
>>>   drivers/spi/spi-loongson-pci.c  |  89 ++++++++++
>>>   drivers/spi/spi-loongson-plat.c |  66 +++++++
>>>   drivers/spi/spi-loongson.h      |  41 +++++
>>>   7 files changed, 536 insertions(+)
>>>   create mode 100644 drivers/spi/spi-loongson-core.c
>>>   create mode 100644 drivers/spi/spi-loongson-pci.c
>>>   create mode 100644 drivers/spi/spi-loongson-plat.c
>>>   create mode 100644 drivers/spi/spi-loongson.h
>>
>> Your patches still have build warnings. Are these false postives or you
>> forgot to build it? Anyway, please respond to the report.
>>
>> Best regards,
>> Krzysztof
> thanks your reminder, I have already provided feedback about compile issue.

Then please test your patches before sending...

Best regards,
Krzysztof