linux-kernel - Re: [PATCH v3 1/2] dt-bindings: spi: add loongson spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be027670-f60d-1fce-5dcd-b406824f26e0@loongson.cn>
Date:   Mon, 27 Mar 2023 17:11:52 +0800
From:   zhuyinbo <zhuyinbo@...ngson.cn>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh@...nel.org>
Cc:     Mark Brown <broonie@...nel.org>, loongson-kernel@...ts.loongnix.cn,
        wanghongliang@...ngson.cn, Liu Peibao <liupeibao@...ngson.cn>,
        linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
        Jianmin Lv <lvjianmin@...ngson.cn>,
        linux-kernel@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, zhuyinbo@...ngson.cn
Subject: Re: [PATCH v3 1/2] dt-bindings: spi: add loongson spi



在 2023/3/27 下午4:52, Krzysztof Kozlowski 写道:
> On 27/03/2023 10:39, zhuyinbo wrote:
>>
>>
>> 在 2023/3/24 下午9:07, Rob Herring 写道:
>>>
>>> On Fri, 24 Mar 2023 14:33:16 +0800, Yinbo Zhu wrote:
>>>> Add the Loongson platform spi binding with DT schema format using
>>>> json-schema.
>>>>
>>>> Signed-off-by: Yinbo Zhu <zhuyinbo@...ngson.cn>
>>>> ---
>>>>    .../bindings/spi/loongson,ls-spi.yaml         | 43 +++++++++++++++++++
>>>>    MAINTAINERS                                   |  6 +++
>>>>    2 files changed, 49 insertions(+)
>>>>    create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml
>>>>
>>>
>>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>>
>>> yamllint warnings/errors:
>>>
>>> dtschema/dtc warnings/errors:
>>> Error: Documentation/devicetree/bindings/spi/loongson,ls-spi.example.dts:22.28-29 syntax error
>>> FATAL ERROR: Unable to parse input tree
>>> make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/spi/loongson,ls-spi.example.dtb] Error 1
>>> make[1]: *** Waiting for unfinished jobs....
>>> make: *** [Makefile:1512: dt_binding_check] Error 2
>> Hi Rob Herring,
>>
>> This error was still appears on 22 line, this line was
>> LOONGSON2_BOOT_CLK not refer, it need depend on
>> https://lore.kernel.org/all/20230323025229.2971-1-zhuyinbo@loongson.cn/
>> then compile will be successful. and I had added this depend on
>> description in v2, v3 patch changelog, I was also send a email to remind
>> your bot for the test my patch need dpend on other clock patch.
> 
> ... and did you read Rob's advice?yes
For some reason you responded to
> automated bot's email, but not to actual email from Rob.
okay, I got it.
> 
> Best regards,
> Krzysztof
>