lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <44904ffc-83d4-1137-3479-737a81b31d16@linaro.org> Date: Mon, 27 Mar 2023 14:22:19 +0200 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Dylan Van Assche <me@...anvanassche.be>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Amol Maheshwari <amahesh@....qualcomm.com>, Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org> Cc: Konrad Dybcio <konrad.dybcio@...aro.org>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: add qcom,assign-all-memory property On 27/03/2023 13:37, Dylan Van Assche wrote: > Hi Krzysztof, > > On Sun, 2023-03-26 at 10:55 +0200, Krzysztof Kozlowski wrote: >> On 25/03/2023 14:44, Dylan Van Assche wrote: >>> Document the added qcom,assign-all-memory in devicetree bindings. >>> >>> Signed-off-by: Dylan Van Assche <me@...anvanassche.be> >>> --- >>> Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 6 >>> ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml >>> b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml >>> index 1ab9588cdd89..fa5b00534b30 100644 >>> --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml >>> +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml >>> @@ -57,6 +57,12 @@ properties: >>> Virtual machine IDs for remote processor. >>> $ref: "/schemas/types.yaml#/definitions/uint32-array" >>> >>> + qcom,assign-all-mem: >>> + description: >>> + Assign memory to all Virtual machines defined by qcom,vmids. >> >> This (neither commit msg) does not explain why this is needed and >> actually does not sound like hardware-related property. > > This is made a separate property to toggle different behavior in the > driver if it is needed for some FastRPC nodes. Bindings are not for driver behavior. > Downstream does guard > this with a property 'restrict-access' as well, see [1] for a random > SDM845 downstream kernel. On SDM845, this property is not present, thus > the IF block runs. On SDM670, this property is present, then the IF > block is skipped. That's why I opt for this property to have this > behaviour conditionally. I'm not sure how to explain it better though. Still you described driver... Please come with something more hardware related. Best regards, Krzysztof
Powered by blists - more mailing lists