[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZCGK4+zUDT1lLz6s@khadija-virtual-machine>
Date: Mon, 27 Mar 2023 17:24:03 +0500
From: Khadija Kamran <kamrankhadijadj@...il.com>
To: outreachy@...ts.linux.dev
Cc: Marc Dietrich <marvin24@....de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
ac100@...ts.launchpad.net, linux-tegra@...r.kernel.org,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: [PATCH] staging: nvec: replace udelay() with usleep_range()
Replace 'udelay()' with 'usleep_range()' with 1000us as upper limit.
This issue is reported by checkpatch.pl script.
CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.rst
Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
---
drivers/staging/nvec/nvec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index b3f114cb00dc..1b51935dba4f 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -627,7 +627,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
break;
case 2: /* first byte after command */
if (status == (I2C_SL_IRQ | RNW | RCVD)) {
- udelay(33);
+ usleep_range(33, 1000);
if (nvec->rx->data[0] != 0x01) {
dev_err(nvec->dev,
"Read without prior read command\n");
@@ -714,7 +714,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
* We experience less incomplete messages with this delay than without
* it, but we don't know why. Help is appreciated.
*/
- udelay(100);
+ usleep_range(100, 1000);
return IRQ_HANDLED;
}
--
2.34.1
Powered by blists - more mailing lists