linux-kernel - Re: [PATCH] staging: nvec: replace udelay() with usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <453453f4-1496-4735-8fab-efb7e4240e05@kili.mountain>
Date:   Mon, 27 Mar 2023 15:25:43 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Khadija Kamran <kamrankhadijadj@...il.com>
Cc:     outreachy@...ts.linux.dev, Marc Dietrich <marvin24@....de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        ac100@...ts.launchpad.net, linux-tegra@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: nvec: replace udelay() with usleep_range()

On Mon, Mar 27, 2023 at 05:24:03PM +0500, Khadija Kamran wrote:
> Replace 'udelay()' with 'usleep_range()' with 1000us as upper limit.
> This issue is reported by checkpatch.pl script.
> 
> CHECK: usleep_range is preferred over udelay; see
> Documentation/timers/timers-howto.rst
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
> ---

This kind of change requires you to test on the hardware and have
slightly in depth knowledge of the spec.

regards,
dan carpenter