linux-kernel - Re: [PATCH v2 04/15] dmaengine: idxd: Export descriptor management functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79d0618f-950c-f2f0-7286-41e199ba0edb@intel.com>
Date:   Tue, 28 Mar 2023 09:04:21 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Tom Zanussi <tom.zanussi@...ux.intel.com>,
        herbert@...dor.apana.org.au, davem@...emloft.net,
        fenghua.yu@...el.com, vkoul@...nel.org
Cc:     tony.luck@...el.com, wajdi.k.feghali@...el.com,
        james.guilford@...el.com, kanchana.p.sridhar@...el.com,
        giovanni.cabiddu@...el.com, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [PATCH v2 04/15] dmaengine: idxd: Export descriptor management
 functions



On 3/28/23 8:35 AM, Tom Zanussi wrote:
> To allow idxd sub-drivers to access the descriptor management
> functions, export them.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
> ---
>   drivers/dma/idxd/submit.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/dma/idxd/submit.c b/drivers/dma/idxd/submit.c
> index c01db23e3333..9d9ec0b76ccd 100644
> --- a/drivers/dma/idxd/submit.c
> +++ b/drivers/dma/idxd/submit.c
> @@ -61,6 +61,7 @@ struct idxd_desc *idxd_alloc_desc(struct idxd_wq *wq, enum idxd_op_type optype)
>   
>   	return __get_desc(wq, idx, cpu);
>   }
> +EXPORT_SYMBOL_NS_GPL(idxd_alloc_desc, IDXD);
>   
>   void idxd_free_desc(struct idxd_wq *wq, struct idxd_desc *desc)
>   {
> @@ -69,6 +70,7 @@ void idxd_free_desc(struct idxd_wq *wq, struct idxd_desc *desc)
>   	desc->cpu = -1;
>   	sbitmap_queue_clear(&wq->sbq, desc->id, cpu);
>   }
> +EXPORT_SYMBOL_NS_GPL(idxd_free_desc, IDXD);
>   
>   static struct idxd_desc *list_abort_desc(struct idxd_wq *wq, struct idxd_irq_entry *ie,
>   					 struct idxd_desc *desc)
> @@ -215,3 +217,4 @@ int idxd_submit_desc(struct idxd_wq *wq, struct idxd_desc *desc)
>   	percpu_ref_put(&wq->wq_active);
>   	return 0;
>   }
> +EXPORT_SYMBOL_GPL(idxd_submit_desc);

This one should use the EXPORT_SYMBOL_NS_GPL() as above?