linux-kernel - Re: [PATCH v2 06/15] dmaengine: idxd: Add private_data to struct idxd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Mar 2023 09:06:38 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Tom Zanussi <tom.zanussi@...ux.intel.com>,
        herbert@...dor.apana.org.au, davem@...emloft.net,
        fenghua.yu@...el.com, vkoul@...nel.org
Cc:     tony.luck@...el.com, wajdi.k.feghali@...el.com,
        james.guilford@...el.com, kanchana.p.sridhar@...el.com,
        giovanni.cabiddu@...el.com, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [PATCH v2 06/15] dmaengine: idxd: Add private_data to struct
 idxd_wq



On 3/28/23 8:35 AM, Tom Zanussi wrote:
> Add a void * to idxd_wqs for user-defined context data.

I wonder if we should add accessor functions like get and set private 
data for the wq.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
> ---
>   drivers/dma/idxd/idxd.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
> index 719f9f1662ad..e55213b5153e 100644
> --- a/drivers/dma/idxd/idxd.h
> +++ b/drivers/dma/idxd/idxd.h
> @@ -216,6 +216,8 @@ struct idxd_wq {
>   	u32 max_batch_size;
>   
>   	char driver_name[WQ_NAME_SIZE + 1];
> +
> +	void *private_data;
>   };
>   
>   struct idxd_engine {