linux-kernel - Re: [PATCH -next] spi: xilinx: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68ce9aed-f5a0-ff43-27b3-651773eb3258@amd.com>
Date:   Tue, 28 Mar 2023 08:33:07 +0200
From:   Michal Simek <michal.simek@....com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, broonie@...nel.org
Cc:     michal.simek@...inx.com, linux-spi@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] spi: xilinx: Use
 devm_platform_get_and_ioremap_resource()



On 3/28/23 08:15, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>   drivers/spi/spi-xilinx.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 5dd3d1901412..8e6e3876aa9a 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -440,8 +440,7 @@ static int xilinx_spi_probe(struct platform_device *pdev)
>          xspi->bitbang.txrx_bufs = xilinx_spi_txrx_bufs;
>          init_completion(&xspi->done);
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       xspi->regs = devm_ioremap_resource(&pdev->dev, res);
> +       xspi->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>          if (IS_ERR(xspi->regs))
>                  return PTR_ERR(xspi->regs);
> 
> --
> 2.20.1.7.g153144c
> 

Reviewed-by: Michal Simek <michal.simek@....com>

Thanks,
Michal