linux-kernel - Re: [PATCH V4 2/5] cachefiles: extract ondemand info field from cachefiles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <132137.1680011908@warthog.procyon.org.uk>
Date:   Tue, 28 Mar 2023 14:58:28 +0100
From:   David Howells <dhowells@...hat.com>
To:     Jia Zhu <zhujia.zj@...edance.com>
Cc:     dhowells@...hat.com, linux-cachefs@...hat.com,
        linux-erofs@...ts.ozlabs.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Jingbo Xu <jefflexu@...ux.alibaba.com>
Subject: Re: [PATCH V4 2/5] cachefiles: extract ondemand info field from cachefiles_object

Jia Zhu <zhujia.zj@...edance.com> wrote:

> @@ -65,10 +71,7 @@ struct cachefiles_object {
>  	enum cachefiles_content		content_info:8;	/* Info about content presence */
>  	unsigned long			flags;
>  #define CACHEFILES_OBJECT_USING_TMPFILE	0		/* Have an unlinked tmpfile */
> -#ifdef CONFIG_CACHEFILES_ONDEMAND
> -	int				ondemand_id;
> -	enum cachefiles_object_state	state;
> -#endif
> +	struct cachefiles_ondemand_info	*private;

Why is this no longer inside "#ifdef CONFIG_CACHEFILES_ONDEMAND"?

Also, please don't call it "private", but rather something like "ondemand" or
"ondemand_info".

David