linux-kernel - Re: [PATCH V4 3/5] cachefiles: resend an open request if the read request's object is closed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Mar 2023 15:12:24 +0100
From:   David Howells <dhowells@...hat.com>
To:     Jia Zhu <zhujia.zj@...edance.com>
Cc:     dhowells@...hat.com, linux-cachefs@...hat.com,
        linux-erofs@...ts.ozlabs.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, Xin Yin <yinxin.x@...edance.com>,
        Jingbo Xu <jefflexu@...ux.alibaba.com>
Subject: Re: [PATCH V4 3/5] cachefiles: resend an open request if the read request's object is closed

Jia Zhu <zhujia.zj@...edance.com> wrote:

> +	struct cachefiles_object *object =
> +		((struct cachefiles_ondemand_info *)work)->object;

container_of().

> +			continue;
> +		} else if (cachefiles_ondemand_object_is_reopening(object)) {

The "else" is unnecessary.

> +static void ondemand_object_worker(struct work_struct *work)
> +{
> +	struct cachefiles_object *object =
> +		((struct cachefiles_ondemand_info *)work)->object;
> +
> +	cachefiles_ondemand_init_object(object);
> +}

I can't help but feel there's some missing exclusion/locking.  This feels like
it really ought to be driven from the fscache object state machine.