linux-kernel - Re: [PATCH 2/5] orangefs: use folios in orangefs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOg9mSRqNJUmKWaAkZZ_h1T_n1PDN2oPGHfH0z+vfGTUZD=Yow@mail.gmail.com>
Date:   Wed, 29 Mar 2023 15:10:03 -0400
From:   Mike Marshall <hubcap@...ibond.com>
To:     Pankaj Raghav <p.raghav@...sung.com>
Cc:     Matthew Wilcox <willy@...radead.org>, martin@...ibond.com,
        axboe@...nel.dk, minchan@...nel.org, akpm@...ux-foundation.org,
        viro@...iv.linux.org.uk, senozhatsky@...omium.org,
        brauner@...nel.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, mcgrof@...nel.org,
        linux-block@...r.kernel.org, gost.dev@...sung.com,
        linux-mm@...ck.org, devel@...ts.orangefs.org
Subject: Re: [PATCH 2/5] orangefs: use folios in orangefs_readahead

I thought telling you that I tested it was good :-) ...

Please do put a tested-by me in there...

-Mike

On Tue, Mar 28, 2023 at 12:02 PM Pankaj Raghav <p.raghav@...sung.com> wrote:
>
> On 2023-03-28 17:21, Matthew Wilcox wrote:
> > On Tue, Mar 28, 2023 at 01:27:13PM +0200, Pankaj Raghav wrote:
> >> Convert orangefs_readahead() from using struct page to struct folio.
> >> This conversion removes the call to page_endio() which is soon to be
> >> removed, and simplifies the final page handling.
> >>
> >> The page error flags is not required to be set in the error case as
> >> orangefs doesn't depend on them.
> >>
> >> Signed-off-by: Pankaj Raghav <p.raghav@...sung.com>
> >
> > Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> >
> > Shouldn't Mike's tested-by be in here?
>
> I mentioned that he tested in my cover letter as I didn't receive a Tested-by
> tag from him.