linux-kernel - Re: [PATCH 1/2] dmaengine: mv_xor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73af278e-1fc7-43fb-87b9-f107ae533266@kili.mountain>
Date:   Wed, 29 Mar 2023 13:55:05 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>,
        Gregory CLEMENT <gregory.clement@...tlin.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        dmaengine@...r.kernel.org
Subject: Re: [PATCH 1/2] dmaengine: mv_xor_v2: Fix an error code.

A bunch of false positives could be silenced by changing the assign
and return hooks to check for unsigned types:

static void match_assign(struct expression *expr)
{
        if (expr_unsigned(expr->left))
                return;
        warn_on_positive_error(expr->right);
}

static void match_return(struct expression *expr)
{
        struct symbol *type;

        type = cur_func_return_type();
        if (type_unsigned(type))
                return;

        warn_on_positive_error(expr);
}

regards,
dan carpenter