linux-kernel - Re: [PATCH v1 1/1] gpiolib: Split property name from the warning message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MeBbdHYV-_2utMBVy-31GzGbWM8GUD9RRV8vYQ3OzHWrA@mail.gmail.com>
Date:   Wed, 29 Mar 2023 13:37:16 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/1] gpiolib: Split property name from the warning message

On Tue, Mar 21, 2023 at 2:52 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Split property name from the warning message to make object file
> shorter. The linker will use the single copy of it. It's fine
> to pass a pointer to the printing function since it's a slow path
> anyway.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/gpio/gpiolib.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 51a19cbe39a4..112d99a5eec4 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -403,8 +403,8 @@ static int gpiochip_set_names(struct gpio_chip *chip)
>          * gpiochips.
>          */
>         if (count <= chip->offset) {
> -               dev_warn(dev, "gpio-line-names too short (length %d), cannot map names for the gpiochip at offset %u\n",
> -                        count, chip->offset);
> +               dev_warn(dev, "%s too short (length %d), cannot map names for the gpiochip at offset %u\n",
> +                        "gpio-line-names", count, chip->offset);
>                 return 0;
>         }
>
> --
> 2.40.0.1.gaa8946217a0b
>

I'd say being able to grep the code easily for messages is more
important than saving a couple bytes here?

Bart