linux-kernel - Re: [PATCH v1 1/1] gpiolib: Split property name from the warning message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZCRDUp2sniTQWdFU@smile.fi.intel.com>
Date:   Wed, 29 Mar 2023 16:55:30 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/1] gpiolib: Split property name from the warning
 message

On Wed, Mar 29, 2023 at 01:37:16PM +0200, Bartosz Golaszewski wrote:
> On Tue, Mar 21, 2023 at 2:52 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:

...

> > -               dev_warn(dev, "gpio-line-names too short (length %d), cannot map names for the gpiochip at offset %u\n",
> > -                        count, chip->offset);
> > +               dev_warn(dev, "%s too short (length %d), cannot map names for the gpiochip at offset %u\n",
> > +                        "gpio-line-names", count, chip->offset);
> >                 return 0;
> >         }
> 
> I'd say being able to grep the code easily for messages is more
> important than saving a couple bytes here?

We still grep by the rest of the message. But anyway, up to you,
I've no hard feelings to this patch.

-- 
With Best Regards,
Andy Shevchenko