linux-kernel - Re: [PATCH] leds: rgb: mt6370: fix CONFIG_LINEAR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Mar 2023 18:05:33 +0100
From:   Lee Jones <lee@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Pavel Machek <pavel@....cz>, ChiYuan Huang <cy_huang@...htek.com>,
        Arnd Bergmann <arnd@...db.de>,
        Alice Chen <alice_chen@...htek.com>,
        Sven Schwermer <sven.schwermer@...ruptive-technologies.com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        ChiaEn Wu <chiaen_wu@...htek.com>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: rgb: mt6370: fix CONFIG_LINEAR_RANGES select

On Tue, 28 Mar 2023, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@...db.de>
>
> CONFIG_LINEAR_RANGE does not exist, but selecting is silently ignored.
>
> ERROR: modpost: "linear_range_get_selector_within" [drivers/leds/rgb/leds-mt6370-rgb.ko] undefined!
>
> Fixes: 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/leds/rgb/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Beaten to it I'm afraid:

https://lore.kernel.org/r/20230323105410.10396-1-lukas.bulwahn@gmail.com

> diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
> index 7d86bb26c54b..360c8679c6e2 100644
> --- a/drivers/leds/rgb/Kconfig
> +++ b/drivers/leds/rgb/Kconfig
> @@ -29,7 +29,7 @@ config LEDS_QCOM_LPG
>  config LEDS_MT6370_RGB
>  	tristate "LED Support for MediaTek MT6370 PMIC"
>  	depends on MFD_MT6370
> -	select LINEAR_RANGE
> +	select LINEAR_RANGES
>  	help
>  	  Say Y here to enable support for MT6370_RGB LED device.
>  	  In MT6370, there are four channel current-sink LED drivers that
> --
> 2.39.2
>

--
Lee Jones [李琼斯]