linux-kernel - Re: [PATCH -next] dma-debug: Use %pa to format phys_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5db9b27a-90df-4916-90da-4e8daeebf9e3@app.fastmail.com>
Date:   Thu, 30 Mar 2023 08:51:15 +0200
From:   "Arnd Bergmann" <arnd@...nel.org>
To:     "Christoph Hellwig" <hch@...radead.org>,
        "Geert Uytterhoeven" <geert+renesas@...der.be>
Cc:     "Desnes Nunes" <desnesn@...hat.com>,
        "Christoph Hellwig" <hch@....de>,
        "Marek Szyprowski" <m.szyprowski@...sung.com>,
        "Robin Murphy" <robin.murphy@....com>, iommu@...ts.linux.dev,
        linux-kernel@...r.kernel.org, "kernel test robot" <lkp@...el.com>,
        noreply@...erman.id.au
Subject: Re: [PATCH -next] dma-debug: Use %pa to format phys_addr_t

On Thu, Mar 30, 2023, at 01:50, Christoph Hellwig wrote:
> I've applied this as it is the first fix I got into my mailbox for it.
>
> Arnd sent one a little later, which uses %pap instead of %pa, which
> confused me a bit.  The documentation seems to allow both without
> any recommendation which one to use, which confuses me even further.

Indeed, I wasn't aware of this either, apparently aaf07621b8bb
("vsprintf: add %pad extension for dma_addr_t use") introduced the
%pap form at the same time as %pad but made it the same as the already
existing %pa. I also see that the %pa form is a lot more common than
%pap, so it's probably better to go with %pa for new users anyway.

    Arnd