linux-kernel - Re: [PATCH tty-next 2/2] serial: 8250: add driver for NI UARTs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <862a78b5-b89a-0b26-e0f8-f910dd3434ba@ni.com>
Date:   Fri, 31 Mar 2023 12:59:33 -0500
From:   Brenda Streiff <brenda.streiff@...com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     Gratian Crisan <gratian.crisan@...com>,
        Jason Smith <jason.smith@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        devicetree@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH tty-next 2/2] serial: 8250: add driver for NI UARTs

On 3/31/23 06:46, Ilpo Järvinen wrote:
> On Wed, 29 Mar 2023, Brenda Streiff wrote:
> 
>> +static int ni16550_get_regs(struct platform_device *pdev,
>> +			    struct uart_port *port)
>> +{
>> +	struct resource *regs;
>> +
>> +	regs = platform_get_resource(pdev, IORESOURCE_IO, 0);
>> +	if (regs) {
>> +		port->iotype = UPIO_PORT;
>> +		port->iobase = regs->start;
>> +
>> +		return 0;
>> +	}
> 
> Do you need the port io?

Yes; on our x86_64 hardware this UART IP is in logic connected to LPC,
and the registers lie in I/O port space.


>> +	int irq;
>> +	int rs232_property = 0;
>> +	unsigned int prescaler;
>> +	const char *transceiver;
>> +	int txfifosz, rxfifosz;
> 
> Try to follow reverse xmas-tree order.

Is reverse xmas tree also the rule in the tty subsystem? I was aware of
it for netdev but I thought that was a netdev-specific rule (since it
only shows up in maintainer-netdev.rst and not more broadly)