linux-kernel - Re: [v2] wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <168027426945.32751.18184826221598610178.kvalo@kernel.org>
Date:   Fri, 31 Mar 2023 14:51:10 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Wei Chen <harperchen1110@...il.com>
Cc:     pkshih@...ltek.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Wei Chen <harperchen1110@...il.com>
Subject: Re: [v2] wifi: rtlwifi: fix incorrect error codes in
 rtl_debugfs_set_write_rfreg()

Wei Chen <harperchen1110@...il.com> wrote:

> If there is a failure during copy_from_user or user-provided data buffer
> is invalid, rtl_debugfs_set_write_rfreg should return negative error code
> instead of a positive value count.
> 
> Fix this bug by returning correct error code. Moreover, the check of buffer
> against null is removed since it will be handled by copy_from_user.
> 
> Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
> Signed-off-by: Wei Chen <harperchen1110@...il.com>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>

Patch applied to wireless-next.git, thanks.

905a9241e4e8 wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_rfreg()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230326053138.91338-1-harperchen1110@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches