linux-kernel - RE: [PATCH] clocksource/drivers/exynos_mct: explicitly return 0 for shared timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <039c01d9664c$5070aed0$f1520c70$@samsung.com>
Date:   Mon, 3 Apr 2023 22:19:48 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        "'Daniel Lezcano'" <daniel.lezcano@...aro.org>,
        "'Thomas Gleixner'" <tglx@...utronix.de>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>
Cc:     "'Vincent Whitchurch'" <vincent.whitchurch@...s.com>,
        "'kernel test robot'" <lkp@...el.com>,
        "'Dan Carpenter'" <error27@...il.com>
Subject: RE: [PATCH] clocksource/drivers/exynos_mct: explicitly return 0 for
 shared timer

Hello Krzysztof

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Monday, April 3, 2023 3:10 PM
> To: Daniel Lezcano <daniel.lezcano@...aro.org>; Thomas Gleixner
> <tglx@...utronix.de>; Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org>;
> Alim Akhtar <alim.akhtar@...sung.com>; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-samsung-soc@...r.kernel.org
> Cc: Vincent Whitchurch <vincent.whitchurch@...s.com>; kernel test robot
> <lkp@...el.com>; Dan Carpenter <error27@...il.com>
> Subject: [PATCH] clocksource/drivers/exynos_mct: explicitly return 0 for
> shared timer
> 
> For a shared timers, the mct_init_dt() should not initialize the clock
even with
> global comparator.  This is not an error, thus the function should simply
> return 0, not 'ret'.
> 
> This also fixes smatch warning:
> 
>   drivers/clocksource/exynos_mct.c:635 mct_init_dt() warn: missing error
> code? 'ret'
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <error27@...il.com>
> Link: https://lore.kernel.org/r/202304021446.46XVKag0-lkp@intel.com/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

>  drivers/clocksource/exynos_mct.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/exynos_mct.c
> b/drivers/clocksource/exynos_mct.c
> index bfd60093ee1c..ef8cb1b71be4 100644
> --- a/drivers/clocksource/exynos_mct.c
> +++ b/drivers/clocksource/exynos_mct.c
> @@ -677,17 +677,17 @@ static int __init mct_init_dt(struct device_node
> *np, unsigned int int_type)
>  	if (ret)
>  		return ret;
> 
>  	/*
>  	 * When the FRC is shared with a main processor, this secondary
>  	 * processor cannot use the global comparator.
>  	 */
>  	if (frc_shared)
> -		return ret;
> +		return 0;
> 
>  	return exynos4_clockevent_init();
>  }
> 
> 
>  static int __init mct_init_spi(struct device_node *np)  {
>  	return mct_init_dt(np, MCT_INT_SPI);
> --
> 2.34.1