linux-kernel - Re: [PATCH] clocksource/drivers/exynos_mct: explicitly return 0 for shared timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db70b75c3eb4160ae25e6f0d6a8219f032cfb416.camel@axis.com>
Date:   Mon, 3 Apr 2023 12:59:17 +0000
From:   Vincent Whitchurch <Vincent.Whitchurch@...s.com>
To:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>
CC:     Vincent Whitchurch <Vincent.Whitchurch@...s.com>,
        "lkp@...el.com" <lkp@...el.com>,
        "error27@...il.com" <error27@...il.com>
Subject: Re: [PATCH] clocksource/drivers/exynos_mct: explicitly return 0 for
 shared timer

On Mon, 2023-04-03 at 11:40 +0200, Krzysztof Kozlowski wrote:
> For a shared timers, the mct_init_dt() should not initialize the clock
> even with global comparator.  This is not an error, thus the function
> should simply return 0, not 'ret'.
> 
> This also fixes smatch warning:
> 
>   drivers/clocksource/exynos_mct.c:635 mct_init_dt() warn: missing error code? 'ret'
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <error27@...il.com>
> Link: https://lore.kernel.org/r/202304021446.46XVKag0-lkp@intel.com/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Vincent Whitchurch <vincent.whitchurch@...s.com>