linux-kernel - Re: [PATCH 1/5] driver core: class: mark class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iULFnO7Ap3xXWGLJbdL3M33p9wzmHv=xp4g7iCfmPfqg@mail.gmail.com>
Date:   Mon, 3 Apr 2023 19:55:50 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, rafael@...nel.org
Subject: Re: [PATCH 1/5] driver core: class: mark class_release() as taking a
 const *

On Sun, Apr 2, 2023 at 7:59 PM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> The struct class callback, class_release(), is only called in 2 places,
> the pcmcia cardservices code, and in the class driver core code.  Both
> places it is safe to mark the structure as a const *, to allow us to
> in the future mark all struct class usages as constant and move into
> read-only memory.
>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Acked-by: Rafael J. Wysocki <rafael@...nel.org>

> ---
>  drivers/base/class.c         | 2 +-
>  drivers/pcmcia/cs.c          | 2 +-
>  include/linux/device/class.h | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/class.c b/drivers/base/class.c
> index 65502bd7d5c5..53fc7052340c 100644
> --- a/drivers/base/class.c
> +++ b/drivers/base/class.c
> @@ -235,7 +235,7 @@ void class_unregister(const struct class *cls)
>  }
>  EXPORT_SYMBOL_GPL(class_unregister);
>
> -static void class_create_release(struct class *cls)
> +static void class_create_release(const struct class *cls)
>  {
>         pr_debug("%s called for %s\n", __func__, cls->name);
>         kfree(cls);
> diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c
> index e3224e49c43f..5658745c398f 100644
> --- a/drivers/pcmcia/cs.c
> +++ b/drivers/pcmcia/cs.c
> @@ -824,7 +824,7 @@ static int pcmcia_socket_uevent(const struct device *dev,
>
>  static struct completion pcmcia_unload;
>
> -static void pcmcia_release_socket_class(struct class *data)
> +static void pcmcia_release_socket_class(const struct class *data)
>  {
>         complete(&pcmcia_unload);
>  }
> diff --git a/include/linux/device/class.h b/include/linux/device/class.h
> index 7e4a1a6329f4..f3c418fa129a 100644
> --- a/include/linux/device/class.h
> +++ b/include/linux/device/class.h
> @@ -58,7 +58,7 @@ struct class {
>         int (*dev_uevent)(const struct device *dev, struct kobj_uevent_env *env);
>         char *(*devnode)(const struct device *dev, umode_t *mode);
>
> -       void (*class_release)(struct class *class);
> +       void (*class_release)(const struct class *class);
>         void (*dev_release)(struct device *dev);
>
>         int (*shutdown_pre)(struct device *dev);
> --
> 2.40.0
>