linux-kernel - Re: [PATCH 4/5] driver core: class: remove struct class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Apr 2023 09:43:18 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     rafael@...nel.org, Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Kurt Schwemmer <kurt.schwemmer@...rosemi.com>,
        Jon Mason <jdmason@...zu.us>,
        Dave Jiang <dave.jiang@...el.com>,
        Allen Hubbe <allenbh@...il.com>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Matt Porter <mporter@...nel.crashing.org>,
        Alexandre Bounine <alex.bou9@...il.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Doug Gilbert <dgilbert@...erlog.com>,
        John Stultz <jstultz@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Wang Weiyang <wangweiyang2@...wei.com>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Jakob Koschel <jakobkoschel@...il.com>,
        Cai Xinchen <caixinchen1@...wei.com>
Subject: Re: [PATCH 4/5] driver core: class: remove struct class_interface *
 from callbacks



On 2023-04-02 11:58, Greg Kroah-Hartman wrote:
> The add_dev and remove_dev callbacks in struct class_interface currently
> pass in a pointer back to the class_interface structure that is calling
> them, but none of the callback implementations actually use this pointer
> as it is pointless (the structure is known, the driver passed it in in
> the first place if it is really needed again.)
> 
> So clean this up and just remove the pointer from the callbacks and fix
> up all callback functions.
> 
> Cc: Jean Delvare <jdelvare@...e.com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Kurt Schwemmer <kurt.schwemmer@...rosemi.com>
> Cc: Logan Gunthorpe <logang@...tatee.com>
> Cc: Jon Mason <jdmason@...zu.us>
> Cc: Dave Jiang <dave.jiang@...el.com>
> Cc: Allen Hubbe <allenbh@...il.com>
> Cc: Dominik Brodowski <linux@...inikbrodowski.net>
> Cc: Matt Porter <mporter@...nel.crashing.org>
> Cc: Alexandre Bounine <alex.bou9@...il.com>
> Cc: "James E.J. Bottomley" <jejb@...ux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@...cle.com>
> Cc: Doug Gilbert <dgilbert@...erlog.com>
> Cc: John Stultz <jstultz@...gle.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Wang Weiyang <wangweiyang2@...wei.com>
> Cc: Yang Yingliang <yangyingliang@...wei.com>
> Cc: Jakob Koschel <jakobkoschel@...il.com>
> Cc: Cai Xinchen <caixinchen1@...wei.com>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
> Note, subsystem maintainers, this should go through my driver-core tree
> as it's part of a larger cleanup of 'struct class' handling.  I'm cc:ing
> you all to get reviews to verify I didn't do something foolish, but it
> has passed 0-day bot build testing already (which caught many foolish
> mistakes of mine...)
> 
> 
>  drivers/base/class.c                     |  4 ++--
>  drivers/base/core.c                      | 10 ++++------
>  drivers/hwmon/drivetemp.c                |  4 ++--
>  drivers/net/rionet.c                     |  3 +--
>  drivers/ntb/hw/mscc/ntb_hw_switchtec.c   |  6 ++----

For the switchtec changes:

Acked-by: Logan Gunthorpe <logang@...tatee.com>

Thanks!

Logan