linux-kernel - Re: [PATCH v3 4/4] mfd: tps6586x: register restart handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab4d8e1e-d378-85d2-34aa-404ff178c49f@collabora.com>
Date:   Mon, 3 Apr 2023 18:44:16 +0300
From:   Dmitry Osipenko <dmitry.osipenko@...labora.com>
To:     Benjamin Bara <bbara93@...il.com>
Cc:     benjamin.bara@...data.com, jonathanh@...dia.com, lee@...nel.org,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, rafael.j.wysocki@...el.com,
        richard.leitner@...ux.dev, treding@...dia.com, wsa@...nel.org
Subject: Re: [PATCH v3 4/4] mfd: tps6586x: register restart handler

On 4/3/23 09:50, Benjamin Bara wrote:
> Thanks for the feedback!
> 
> The DS states: "When the reboot request state is set an internal timer TWAIT
> (10ms typ) is started. The reboot request ends when t > TWAIT."
> 
> Therefore, my intention was to wait a little bit before starting the next
> handler in the chain. I can do some tests without the mdelay, but otherwise
> will reduce it to 15ms in the next patch. What do you think about it?

Sounds good. Please add a clarifying comment for the delay to the code.

-- 
Best regards,
Dmitry