linux-kernel - RE: [PATCH v2] PCI: hv: Fix the definition of vector in hv_compose_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SA1PR21MB13359EE68C74282FD9B75168BF929@SA1PR21MB1335.namprd21.prod.outlook.com>
Date:   Mon, 3 Apr 2023 18:29:23 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jose Teuttli Carranco <josete@...rosoft.com>
CC:     Boqun Feng <boqun.feng@...il.com>,
        "quic_jhugo@...cinc.com" <quic_jhugo@...cinc.com>,
        "quic_carlv@...cinc.com" <quic_carlv@...cinc.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "sthemmin@...rosoft.com" <sthemmin@...rosoft.com>,
        "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Michael Kelley (LINUX)" <mikelley@...rosoft.com>,
        "robh@...nel.org" <robh@...nel.org>, "kw@...ux.com" <kw@...ux.com>,
        "helgaas@...nel.org" <helgaas@...nel.org>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Sasha Levin <sashal@...nel.org>
Subject: RE: [PATCH v2] PCI: hv: Fix the definition of vector in
 hv_compose_msi_msg()

> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Sent: Monday, April 3, 2023 6:08 AM
> To: Dexuan Cui <decui@...rosoft.com>
> Cc: Boqun Feng <boqun.feng@...il.com>; quic_jhugo@...cinc.com;
> quic_carlv@...cinc.com; wei.liu@...nel.org; KY Srinivasan
> <kys@...rosoft.com>; Haiyang Zhang <haiyangz@...rosoft.com>;
> sthemmin@...rosoft.com; lpieralisi@...nel.org; bhelgaas@...gle.com;
> linux-hyperv@...r.kernel.org; linux-pci@...r.kernel.org;
> linux-kernel@...r.kernel.org; Michael Kelley (LINUX)
> <mikelley@...rosoft.com>; robh@...nel.org; kw@...ux.com;
> helgaas@...nel.org; alex.williamson@...hat.com; stable@...r.kernel.org;
> Sasha Levin <sashal@...nel.org>
> Subject: Re: [PATCH v2] PCI: hv: Fix the definition of vector in
> hv_compose_msi_msg()
> 
> On Thu, Mar 30, 2023 at 03:23:45AM +0000, Dexuan Cui wrote:
> > > From: Boqun Feng <boqun.feng@...il.com>
> > > Sent: Wednesday, March 29, 2023 7:56 PM
> > > To: Dexuan Cui <decui@...rosoft.com>
> > >  ...
> > > On Wed, Mar 29, 2023 at 06:56:12PM -0700, Boqun Feng wrote:
> > > > [Cc stable]
> > > >
> > > > On Thu, Oct 27, 2022 at 01:52:56PM -0700, Dexuan Cui wrote:
> > > > > The local variable 'vector' must be u32 rather than u8: see the
> > > > > struct hv_msi_desc3.
> > > > >
> > > > > 'vector_count' should be u16 rather than u8: see struct hv_msi_desc,
> > > > > hv_msi_desc2 and hv_msi_desc3.
> > > > >
> > > >
> > > > Dexuan, I think this patch should only be in 5.15, because...
> > > >
> > >
> > > Sorry, I meant:
> > >
> > > "this patch should also be backported in 5.15"
> > >
> > > Regards,
> > > Boqun
> > >
> > > > > Fixes: a2bad844a67b ("PCI: hv: Fix interrupt mapping for multi-MSI")
> > > >
> > > > ^^^ this commit is already in 5.15.y (commit id 92dcb50f7f09).
> > > >
> > > > Upstream id e70af8d040d2b7904dca93d942ba23fb722e21b1
> > > > Cc: <stable@...r.kernel.org> # 5.15.x
> >
> > The faulty commit a2bad844a67b ("PCI: hv: Fix interrupt mapping for
> multi-MSI")
> > is in all the stable branches, even including 4.14.y, so yes, the commit
> > e70af8d040d2 ("PCI: hv: Fix the definition of vector in
> hv_compose_msi_msg()")
> > should be backported to all the stable branches as well, including
> > v5.15.y, v5.10.y, v5.4.y, v4.19.y, v4.14.y.
> >
> > e70af8d040d2 has a Fixes tag. Not sure why it's not automatically
> backported.
> 
> Also, the most obvious reason, it does NOT apply there!  If this needs
> to go to 5.15.y and older, please send working backports of it.
> 
> thanks,
> 
> greg k-h

I also found that we need to manually rebase the patch for 5.15.y
and older. +Jose, who will help to do the backport.