linux-kernel - Re: [PATCH] x86: profiling: Using generic unwinding in profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96d44033-3bfd-840b-15d7-80dd3a1a5313@linux.intel.com>
Date:   Mon, 3 Apr 2023 11:29:52 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Chen Zhongjin <chenzhongjin@...wei.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "hpa@...or.com" <hpa@...or.com>
Subject: Re: [PATCH] x86: profiling: Using generic unwinding in profile_pc


On 4/2/2023 6:24 PM, Chen Zhongjin wrote:
> Just ping... Or has profile code already been obsoleted?


I think it would be reasonable to remove the locked functions hack since 
lock profiling can be handled with much better other tools these days.

I wouldn't make it depend on the generic unwinder since such a low level 
facility is likely better off without complex dependencies that could break.

-Andi