linux-kernel - Re: [PATCH] x86: profiling: Using generic unwinding in profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 4 Apr 2023 10:03:33 +0800
From:   Chen Zhongjin <chenzhongjin@...wei.com>
To:     Andi Kleen <ak@...ux.intel.com>, "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "hpa@...or.com" <hpa@...or.com>
Subject: Re: [PATCH] x86: profiling: Using generic unwinding in profile_pc


On 2023/4/4 2:29, Andi Kleen wrote:
>
> On 4/2/2023 6:24 PM, Chen Zhongjin wrote:
>> Just ping... Or has profile code already been obsoleted?
>
>
> I think it would be reasonable to remove the locked functions hack 
> since lock profiling can be handled with much better other tools these 
> days.
>
> I wouldn't make it depend on the generic unwinder since such a low 
> level facility is likely better off without complex dependencies that 
> could break.
>
> -Andi
>
>
Although now the generic unwinder on x86 is quite stable... I think it's 
acceptable to remove the locked functions unwinding
for !FP case and leave the FP part as is.

I'll send a new patch for this with another bugfix.

Thanks for review and best,
Chen