linux-kernel - Re: [PATCH v3 04/11] scsi: scsi_debug: Protect block_unblock_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <feafb4e6-2203-5916-f3f4-d59a4981556e@interlog.com>
Date:   Mon, 3 Apr 2023 01:11:13 -0400
From:   Douglas Gilbert <dgilbert@...erlog.com>
To:     John Garry <john.g.garry@...cle.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        bvanassche@....org
Subject: Re: [PATCH v3 04/11] scsi: scsi_debug: Protect
 block_unblock_all_queues() with mutex

On 2023-03-27 03:43, John Garry wrote:
> There is no reason that calls to block_unblock_all_queues() from different
> context can't race with one another, so protect with the
> sdebug_host_list_mutex. There's no need for a more fine-grained per shost
> locking here (and we don't have a per-host lock anyway).
> 
> Also simplify some touched code in sdebug_change_qdepth().
> 
> Signed-off-by: John Garry <john.g.garry@...cle.com>
Acked-by: Douglas Gilbert <dgilbert@...erlog.com>

Thanks.