linux-kernel - Re: [PATCH v3 05/11] scsi: scsi_debug: Use scsi_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a137ccb-6a92-3fc6-dfbd-f6a6273e501d@interlog.com>
Date:   Mon, 3 Apr 2023 01:13:36 -0400
From:   Douglas Gilbert <dgilbert@...erlog.com>
To:     John Garry <john.g.garry@...cle.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        bvanassche@....org
Subject: Re: [PATCH v3 05/11] scsi: scsi_debug: Use scsi_block_requests() to
 block queues

On 2023-03-27 03:43, John Garry wrote:
> The feature to block queues is quite dubious, since it races with in-flight
> IO. Indeed, it seems unnecessary for block queues for any times we do so.
> 
> Anyway, to keep the same behaviour, use standard SCSI API to stop IO being
> sent - scsi_{un}block_requests().
> 
> Signed-off-by: John Garry <john.g.garry@...cle.com>
Acked-by: Douglas Gilbert <dgilbert@...erlog.com>

Thanks.