[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <33b8501c-f617-3f66-91c4-02f9963e2a2f@pengutronix.de>
Date: Mon, 3 Apr 2023 10:41:51 +0200
From: Ahmad Fatoum <a.fatoum@...gutronix.de>
To: Clark Wang <xiaoning.wang@....com>, peppe.cavallaro@...com,
alexandre.torgue@...s.st.com, joabreu@...opsys.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, mcoquelin.stm32@...il.com
Cc: netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [Linux-stm32] [PATCH] net: stmmac: remove the limitation of
adding vlan in promisc mode
Hello Clark,
On 03.04.23 10:17, Clark Wang wrote:
> When using brctl to add eqos to a bridge, it will frist set eqos to
> promisc mode and then set a VLAN for this bridge with a filer VID value
> of 1.
>
> These two error returns limit the use of brctl, resulting in the
> inability of the bridge to be enabled on eqos. So remove them.
>
> Signed-off-by: Clark Wang <xiaoning.wang@....com>
Please add a suitable Fixes: tag pointing at the commit introducing
the regression.
Thanks,
Ahmad
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> index 8c7a0b7c9952..64bbe15a699e 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> @@ -472,12 +472,6 @@ static int dwmac4_add_hw_vlan_rx_fltr(struct net_device *dev,
> if (vid > 4095)
> return -EINVAL;
>
> - if (hw->promisc) {
> - netdev_err(dev,
> - "Adding VLAN in promisc mode not supported\n");
> - return -EPERM;
> - }
> -
> /* Single Rx VLAN Filter */
> if (hw->num_vlan == 1) {
> /* For single VLAN filter, VID 0 means VLAN promiscuous */
> @@ -527,12 +521,6 @@ static int dwmac4_del_hw_vlan_rx_fltr(struct net_device *dev,
> {
> int i, ret = 0;
>
> - if (hw->promisc) {
> - netdev_err(dev,
> - "Deleting VLAN in promisc mode not supported\n");
> - return -EPERM;
> - }
> -
> /* Single Rx VLAN Filter */
> if (hw->num_vlan == 1) {
> if ((hw->vlan_filter[0] & GMAC_VLAN_TAG_VID) == vid) {
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists