linux-kernel - Re: [PATCH] fpga: bridge: fix kernel-doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 3 Apr 2023 11:59:33 +0200
From:   Marco Pagani <marpagan@...hat.com>
To:     Xu Yilun <yilun.xu@...el.com>
Cc:     Moritz Fischer <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>,
        Tom Rix <trix@...hat.com>, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fpga: bridge: fix kernel-doc



On 2023-04-02 08:36, Xu Yilun wrote:
> On 2023-03-30 at 19:45:05 +0200, Marco Pagani wrote:
>> Fix the following warnings issued by the kernel-doc script:
>>
>> drivers/fpga/fpga-bridge.c:99: warning: No description found for return value of 'of_fpga_bridge_get'
>> drivers/fpga/fpga-bridge.c:163: warning: No description found for return value of 'fpga_bridges_enable'
>> drivers/fpga/fpga-bridge.c:187: warning: No description found for return value of 'fpga_bridges_disable'
>> drivers/fpga/fpga-bridge.c:238: warning: No description found for return value of 'of_fpga_bridge_get_to_list'
>> drivers/fpga/fpga-bridge.c:268: warning: No description found for return value of 'fpga_bridge_get_to_list'
> 
> I see you are trying to clean up the warnings, but I found more in
> drivers/fpga. Could you help at least fix all core code,
> (of-)fpga-bridge/region/mgr.c/h in series? Thanks.
>

Sure, I'll do it.
 
>>
>> The patch is based on top of 38dbcd697770 ("fpga: bridge: fix kernel-doc parameter description").
> 
> I didn't found this commit, could you elaborate? And you could put this
> info in changelog, don't show it up in mainline.
> 

Sorry, I accidentally put the wrong hash. I was referring to this patch:

https://lore.kernel.org/linux-fpga/20230301140309.512578-1-marpagan@redhat.com/

That has been applied to char-misc-next:

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/commit/drivers/fpga/fpga-bridge.c?h=char-misc-next&id=7ef1a2c1c9dffa177ecc3ea50b7f5ee63a621137

Thanks,
Marco