linux-kernel - Re: [PATCH 1/2] staging: greybus: add a single exit path to arche_platform_wd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <642ae9de5ad28_39845e29467@iweiny-mobl.notmuch>
Date:   Mon, 3 Apr 2023 07:59:42 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     Khadija Kamran <kamrankhadijadj@...il.com>,
        Ira Weiny <ira.weiny@...el.com>
CC:     <outreachy@...ts.linux.dev>, <hvaibhav.linux@...il.com>,
        <johan@...nel.org>, <elder@...nel.org>,
        <gregkh@...uxfoundation.org>, <greybus-dev@...ts.linaro.org>,
        <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
        Alison Schofield <alison.schofield@...el.com>
Subject: Re: [PATCH 1/2] staging: greybus: add a single exit path to
 arche_platform_wd_irq()

Khadija Kamran wrote:
> On Sun, Apr 02, 2023 at 05:37:48PM -0700, Ira Weiny wrote:
> > Khadija Kamran wrote:
> > > arche_platform_wd_irq() function has two exit paths. To make the code
> > > more readable, use only one exit path.
> > > 
> > > Suggested-by: Alison Schofield <alison.schofield@...el.com>
> > 
> > Reviewed-by: Ira Weiny <ira.weiny@...el.com>
> >
> 
> Okay, noted.
> 
> Also, would it be okay to send a patch revision with the changes or
> should I wait for the feedback on Dan's comment. Here is a link to it:
> https://lore.kernel.org/outreachy/6ce8aa34-e600-4d6a-adad-ead8255342e5@kili.mountain/

In this case you are going to need to make a v2 of the _series_.  In the
next revision you send both patches again as V2.  (If you are using b4[*]
it will help to track the series versions.)

I am saying this patch looks good but there are still issues with patch
2/2.  If there are no other comments on 1/2 and you don't make any changes
then you include it with my review tag as v2.

When I do this I make a note of picking up tags like so:

---
Changes from V1:
	Add review tags

If you get other comments and make changes then my review is no longer
valid because you have changed the patch.  In that case make those changes
and make a note.  Then I can see why my review was dropped and, more
importantly, I know why I should look at the patch again.

Then in patch 2/2 make changes as needed.

Ira

[*] https://b4.docs.kernel.org/en/latest/