linux-kernel - Re: [PATCH] nvmem: layouts: sl28vpd: set varaiable sl28vpd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 04 Apr 2023 21:09:32 +0200
From:   Michael Walle <michael@...le.cc>
To:     Tom Rix <trix@...hat.com>
Cc:     srinivas.kandagatla@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmem: layouts: sl28vpd: set varaiable sl28vpd_layout
 storage-class-specifier to static

Am 2023-04-04 18:36, schrieb Tom Rix:
> smatch reports
> drivers/nvmem/layouts/sl28vpd.c:144:21: warning: symbol
>   'sl28vpd_layout' was not declared. Should it be static?
> 
> This variable is only used in one file so it should be static.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Fixes tag?

Reviewed-by: Michael Walle <michael@...le.cc>

-michael