linux-kernel - Re: [PATCH] nvmem: layouts: sl28vpd: set varaiable sl28vpd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <120b6729-c329-ea4d-2f69-f8bc5c2925bf@redhat.com>
Date:   Wed, 5 Apr 2023 05:25:29 -0700
From:   Tom Rix <trix@...hat.com>
To:     Michael Walle <michael@...le.cc>
Cc:     srinivas.kandagatla@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmem: layouts: sl28vpd: set varaiable sl28vpd_layout
 storage-class-specifier to static


On 4/4/23 12:09 PM, Michael Walle wrote:
> Am 2023-04-04 18:36, schrieb Tom Rix:
>> smatch reports
>> drivers/nvmem/layouts/sl28vpd.c:144:21: warning: symbol
>>   'sl28vpd_layout' was not declared. Should it be static?
>>
>> This variable is only used in one file so it should be static.
>>
>> Signed-off-by: Tom Rix <trix@...hat.com>
>
> Fixes tag?
>
I am cleaning all of the similar reports by smatch, there is a couple 
hundred.

Because the code works as-is, I do not consider them broken and needing 
fixes tags.

However I do not mind adding then if they are required.

Tom

> Reviewed-by: Michael Walle <michael@...le.cc>
>
> -michael
>